Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Terraform Provider native MachineID support #44306

Merged
merged 6 commits into from
Jul 26, 2024

Conversation

hugoShaka
Copy link
Contributor

@hugoShaka hugoShaka commented Jul 16, 2024

Implements the second half of RFD 173: adds support for native MachineID terraform joining.

Changelog: Add native MachineID support in the TF provider. The TF provide can now use bot join tokens to connect to Teleport.

@hugoShaka hugoShaka force-pushed the hugo/cleanup-terraform-credential-handling branch 2 times, most recently from 645fc09 to cbdd0d8 Compare July 25, 2024 20:35
Base automatically changed from hugo/cleanup-terraform-credential-handling to master July 25, 2024 21:54
@hugoShaka hugoShaka force-pushed the hugo/terraform-native-machineid-2 branch from 4ffd8fb to da696eb Compare July 25, 2024 22:16
@hugoShaka hugoShaka marked this pull request as ready for review July 25, 2024 22:22
Copy link

The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with changelog: followed by the changelog entries for the PR.

Copy link

🤖 Vercel preview here: https://docs-i0vmez7sb-goteleport.vercel.app/docs/ver/preview

Copy link
Contributor

@strideynet strideynet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it ! Can't wait to update the Spacelift docs etc not to require the custom runner image.

@public-teleport-github-review-bot public-teleport-github-review-bot bot removed the request for review from tigrato July 26, 2024 08:43
Copy link

🤖 Vercel preview here: https://docs-hnws666hn-goteleport.vercel.app/docs/ver/preview

@hugoShaka hugoShaka added this pull request to the merge queue Jul 26, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 26, 2024
@hugoShaka hugoShaka added this pull request to the merge queue Jul 26, 2024
Merged via the queue into master with commit 4003f79 Jul 26, 2024
43 of 44 checks passed
@hugoShaka hugoShaka deleted the hugo/terraform-native-machineid-2 branch July 26, 2024 15:09
hugoShaka added a commit that referenced this pull request Jul 26, 2024
* Add Terraform Provider native MachineID support

* Reject 'token' join method

* lint: fix imports

* re-render TF docs

* fix tests + add license

* lint
hugoShaka added a commit that referenced this pull request Aug 1, 2024
* Add Terraform Provider native MachineID support

* Reject 'token' join method

* lint: fix imports

* re-render TF docs

* fix tests + add license

* lint
hugoShaka added a commit that referenced this pull request Aug 2, 2024
* Add Terraform Provider native MachineID support

* Reject 'token' join method

* lint: fix imports

* re-render TF docs

* fix tests + add license

* lint
hugoShaka added a commit that referenced this pull request Aug 6, 2024
* Add Terraform Provider native MachineID support

* Reject 'token' join method

* lint: fix imports

* re-render TF docs

* fix tests + add license

* lint
marcoandredinis pushed a commit that referenced this pull request Aug 26, 2024
* Add Terraform Provider native MachineID support

* Reject 'token' join method

* lint: fix imports

* re-render TF docs

* fix tests + add license

* lint
github-merge-queue bot pushed a commit that referenced this pull request Aug 26, 2024
)

* Introduce the `tctl terraform env` command (#43664)

* Introduce the `tctl terrafor env` command

* fix tests

* address marco's feedback + use correct b64 lib

* add license

* add created-by label as specified in the RFD

* Update tool/tctl/common/terraform_command.go

Co-authored-by: Roman Tkachenko <[email protected]>

* Apply suggestions from code review

Co-authored-by: Roman Tkachenko <[email protected]>

* Have telpeort create the Terraform default role

* rename use-existing-role -> role, and stop hijacking identity.SSHCACertBytes

* Make the terraform provider role a real preset, rename to 'terraform-provider'

* lint

* Fix tbot's invocation after rebase

---------

Co-authored-by: Roman Tkachenko <[email protected]>

* Refactor Terraform credential loading (#44037)

* Refactor Terraform credential loading

* Warn about expiry

* kip expired credentials

* fixup! kip expired credentials

* Use constants everywhere + add godocs

* fixup! Use constants everywhere + add godocs

* Address marco's feedback

* fixup! Address marco's feedback

* tidy go mod

* lint

* re-render TF docs

* Update v16 version in error message

* Add Terraform Provider native MachineID support (#44306)

* Add Terraform Provider native MachineID support

* Reject 'token' join method

* lint: fix imports

* re-render TF docs

* fix tests + add license

* lint

* tidy go mod

* use v16 client.Expiry() function

---------

Co-authored-by: Roman Tkachenko <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants